Horton

Re: Possibly hard-to-read message

David G. Johnston <david.g.johnston@gmail.com>

View thread
From: "David G. Johnston" <david.g.johnston@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-03-27T01:34:06Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. psql: Reword help message and docs for WATCH_INTERVAL

  2. psql: Clarify help message for WATCH_INTERVAL

  3. psql: Make default \watch interval configurable

On Wed, Mar 26, 2025 at 2:11 AM Daniel Gustafsson <daniel@yesql.se> wrote:

> On 26 Mar 2025, at 04:52, David G. Johnston <david.g.johnston@gmail.com>
> wrote:
> On Tue, Mar 25, 2025 at 8:07 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
> wrote:
>
>
> I came across the following help message added in commit 1a759c83278:
>>
>> +       HELP0("  WATCH_INTERVAL\n"
>> +                 "    number of seconds \\watch by default waits between
>> executing the query buffer\n");
>>
>> It took me a little while to understand it.
>>
>
> I'm on board with tweaking this.
>
>
> How about the attached?  We already have "(default: X)" in other places so
> this
> aligns it better while simplifying the language.
>
>
This change is technically wrong on two points:

I pondered mentioning the 2s interval but the environment variable itself
doesn't have a default, it's either set or unset which determines whether
it provides the default or not.  IMO, adding this detail produces too much
text for little benefit.

Your wording loses the idea that this environment variable only establishes
a new default that can be subsequently overridden by explicitly specifying
an interval to \watch.

David J.