Horton

Re: Not-terribly-safe checks for CRC intrinsic support

David G. Johnston <david.g.johnston@gmail.com>

View thread View on postgr.es
From: "David G. Johnston" <david.g.johnston@gmail.com>
To: Steven Niu <niushiji@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-17T02:01:49Z
Lists: pgsql-hackers 
On Sunday, March 16, 2025, Steven Niu <niushiji@gmail.com> wrote:

>
> +# is missing, we must link not just compile, and store the results in
> global
>
> The "compile" should be "compiler"?
>

No.  Compile is the verb that pairs with link.  Compiler is a noun, its
compliment being the linker.

I’d probably add a comma before the “not” though.  Or maybe: we must also
link and store the results in global

Doesn’t link imply compilation?

David J.

Commits

  1. Be more paranoid in configure's checks for CRC and POPCNT intrinsics.