Re: Stability of queryid in minor versions
David G. Johnston <david.g.johnston@gmail.com>
From: "David G. Johnston" <david.g.johnston@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2024-04-15T02:23:33Z
Lists: pgsql-hackers
On Sun, Apr 14, 2024 at 7:03 PM David Rowley <dgrowleyml@gmail.com> wrote: > On Mon, 15 Apr 2024 at 13:37, David G. Johnston > <david.g.johnston@gmail.com> wrote: > > Seems we can improve things by simply removing the "rule of thumb" > sentence altogether. The prior paragraph states the things the queryid > depends upon at the level of detail the reader needs. > > I don't think that addresses the following, which I mentioned earlier: > > > but not stable across *major* versions does *not* mean stable across > > *minor* versions. The reader is just left guessing if that's true. > > The base assumption here is that changes in the things we don't mention do not influence the queryid. We didn't mention minor versions, changing them doesn't influence the queryid. Now, reading that entire paragraph is a bit of a challenge IMO, and agree, as I subsequently noted, that the sentence you pointed out could be reworked. I stand by my statement that removing the sentence about "rule of thumb" altogether is a win. The prior paragraph should be sufficient - it is technically at the moment but am not opposed to rewording. David J.
Commits
-
Doc: document cases where queryid is stable
- 74a587a009d1 12.19 landed
- e4c76f5eca92 13.15 landed
- c6e229d5f76f 14.12 landed
- 38daca854adb 15.7 landed
- 0d8931c12aa9 16.3 landed
- 2d3389c28c5c 17.0 landed