Re: Changed SRF in targetlist handling
David G. Johnston <david.g.johnston@gmail.com>
From: "David G. Johnston" <david.g.johnston@gmail.com>
To: David Fetter <david@fetter.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2016-05-23T18:30:13Z
Lists: pgsql-hackers
On Mon, May 23, 2016 at 1:44 PM, David Fetter <david@fetter.org> wrote: > On Mon, May 23, 2016 at 01:36:57PM -0400, Tom Lane wrote: > > David Fetter <david@fetter.org> writes: > > > On Mon, May 23, 2016 at 01:10:29PM -0400, Tom Lane wrote: > > >> This seems a bridge too far to me. It's just way too common to do > > >> "select generate_series(1,n)". We could tell people they have to > > >> rewrite to "select * from generate_series(1,n)", but it would be far > > >> more polite to do that for them. > > > > > How about making "TABLE generate_series(1,n)" work? It's even > > > shorter in exchange for some cognitive load. > > > > No thanks --- the word after TABLE ought to be a table name, not some > > arbitrary expression. That's way too much mess to save one keystroke. > > It's not just about saving a keystroke. This change would go with > removing the ability to do SRFs in the target list of a SELECT > query. > If you want to make an argument for doing this regardless of the target list SRF change by all means - but it does absolutely nothing to mitigate the breakage that would result if we choose this path. David J.
Commits
-
Remove obsoleted code relating to targetlist SRF evaluation.
- ea15e18677fc 10.0 landed
-
Doc: improve documentation of new SRF-in-tlist behavior.
- f13a1277aa2d 10.0 landed
-
Move targetlist SRF handling from expression evaluation to new executor node.
- 69f4b9c85f16 10.0 landed
-
Don't split up SRFs when choosing to postpone SELECT output expressions.
- d543170f2fdd 9.6.0 cited