Re: n_ins_since_vacuum stats for aborted transactions

David G. Johnston <david.g.johnston@gmail.com>

From: "David G. Johnston" <david.g.johnston@gmail.com>
To: Sami Imseih <samimseih@gmail.com>
Cc: David Rowley <dgrowleyml@gmail.com>, Mark Dilger <mark.dilger@enterprisedb.com>, Euler Taveira <euler@eulerto.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-04-11T22:03:59Z
Lists: pgsql-hackers
On Fri, Apr 11, 2025 at 12:33 PM Sami Imseih <samimseih@gmail.com> wrote:

>
> > I'm also thinking to reword n_tup_upd, something like:
> >
> > Total number of rows updated.  Subsets of these updates are also tracked
> in n_tup_hot_upd and n_tup_newpage_upd to facilitate performance monitoring.
>
> I think the current explanation is clear enough, I am also not too
> thrilled about the "...to facilitate performance monitoring." since
> the cumulative stats system
> as a whole is known to be used to facilitate perf monitoring.
>

Yeah, it was mostly a style thing - I was trying to avoid using
parentheses, but the existing does make the needed point.


> What do you think of the attached?
>
>
WFM.  Though is there a reason to avoid adding the "why" of the exception
for n_mod_since_analyze?

David J.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Add code comment explaining ins_since_vacuum and aborted inserts

  2. Trigger autovacuum based on number of INSERTs