Re: maximum for auto_explain.log_min_duration doesn't seem to make sense

David G. Johnston <david.g.johnston@gmail.com>

From: "David G. Johnston" <david.g.johnston@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kevin Bloch <kev@codingthat.com>, pgsql-bugs@lists.postgresql.org
Date: 2018-02-23T19:27:29Z
Lists: pgsql-bugs
On Fri, Feb 23, 2018 at 12:25 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> "David G. Johnston" <david.g.johnston@gmail.com> writes:
> > On Fri, Feb 23, 2018 at 11:34 AM, Kevin Bloch <kev@codingthat.com>
> wrote:
> >> According to https://dba.stackexchange.com/a/198429/28774 , this
> setting
> >> maxes out at INT_MAX / 1000, but since it's never multiplied by 1000 or
> any
> >> other number, it seems it should perhaps just be INT_MAX
>
> > ​I suspect that the counter to which that value is being compared also
> > wants to be an INT and if one checks for "val > INT_MAX" then val cannot
> be
> > restricted to an integer (and since we are capturing time we need some
> > unknown buffer).



>
>
In short, seems like a valid complaint to me.
>

​Yeah, I went back and pulled up the code and came to the same conclusion.

David J.
​

Commits

  1. Allow auto_explain.log_min_duration to go up to INT_MAX.