Horton

Re: CI: Add task that runs pgindent

David G. Johnston <david.g.johnston@gmail.com>

View thread
From: "David G. Johnston" <david.g.johnston@gmail.com>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Daniel Gustafsson <daniel@yesql.se>, Jelte Fennema-Nio <me@jeltef.nl>, Tom Lane <tgl@sss.pgh.pa.us>, Florents Tselai <florents.tselai@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Nazir Bilal Yavuz <byavuz81@gmail.com>
Date: 2025-10-23T15:58:23Z
Lists: pgsql-hackers 
On Thu, Oct 23, 2025, 11:14 Peter Geoghegan <pg@bowt.ie> wrote:

> On Wed, Oct 22, 2025 at 8:07 AM Daniel Gustafsson <daniel@yesql.se> wrote:
> > I like the different shape and symbol, but I would probably keep it
> green to
> > indicate that it's informational rather than actionable.  We don't want a
> > flurry of patch re-submissions with only whitespace changes eating CI
> resources
> > when the previous build was successful. Just my €0,02.
>
> I strongly agree that this shouldn't signal to the user that they
> really need to fix the problem. I'd like it if this information was
> presented in the least obtrusive way possible. Constantly worrying
> about a misplaced tab is a waste of time for all concerned.
>


My thought is to use the new tags feature to add/remove a "Needs
Formatting" tag as the indicator.

David J.



>
>
>
>
>