Horton

Re: Further cleanup of pg_dump/pg_restore item selection code

David G. Johnston <david.g.johnston@gmail.com>

View thread View on postgr.es
From: "David G. Johnston" <david.g.johnston@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2018-01-25T05:24:02Z
Lists: pgsql-hackers 
On Wednesday, January 24, 2018, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> I think you might be missing one of the main points here, which is
> that --create is specified as causing both a CREATE DATABASE and a
> reconnect to that database.
>

I missed the implication though I read and even thought about questioning
that aspect (in pg_dump though, not restore).

Should pg_restore fail if asked to --create without a database entry in the
TOC?

David J.

Commits

  1. Clean up some aspects of pg_dump/pg_restore item-selection logic.