Horton

Re: Forbid to DROP temp tables of other sessions

David G. Johnston <david.g.johnston@gmail.com>

View thread
From: "David G. Johnston" <david.g.johnston@gmail.com>
To: Daniil Davydov <3danissimo@gmail.com>
Cc: Steven Niu <niushiji@gmail.com>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>, Andres Freund <andres@anarazel.de>, Thomas Munro <thomas.munro@gmail.com>, Rafia Sabih <rafia.pghackers@gmail.com>, Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2025-03-17T15:09:12Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_basebackup: Add missing PQclear in error path

On Monday, March 17, 2025, Daniil Davydov <3danissimo@gmail.com> wrote:

>
> >
> > 2."you have not any temporary relations" --> "you have no any temporary
> > relations"
> I am not an English speaker, but it seems that "have not" would be
> more correct. Someone has to judge us :)
>
>
Both are not good.

“pg_temp was specified but it contains no relations” [1]

But why are we promoting this situation to an error?  It should be a
relation not found error just like any other and not its own special case.
The fact we create pg_temp only as it is needed is an implementation detail
that should not be visible to the user.  Either by saying pg_temp not found
(possibly at this point) or pretending it does and letting the relation
name lookup produce the error.

David J.

[1] It isn’t part of the style guide but I don’t think we use “you” to
directly refer to the query author in error messages.