Horton

Re: INFORMATION_SCHEMA.routines column routine_definition does not show the source

David G. Johnston <david.g.johnston@gmail.com>

View thread
From: "David G. Johnston" <david.g.johnston@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Erki Eessaar <erki.eessaar@taltech.ee>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Date: 2022-12-02T00:00:05Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add some sanity checks in executor for query ID reporting

  2. Fix psql's \sf and \ef for new-style SQL functions.

Decided to ping this as I don't recall or see it getting patched and the
recent discussion regarding the prosrc field.

On Wed, Nov 3, 2021 at 9:46 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:

> "David G. Johnston" <david.g.johnston@gmail.com> writes:
> > The information schema query consults pg_proc.prosrc directly instead of
> > calling pg_get_functiondef(...) (which didn't exist when the original
> query
> > was written, and hasn't been wrong until now).
>
> pg_get_functiondef would produce more than we want, but it looks like
> pg_get_function_sqlbody() would do.
>
> BTW, while researching this I noted the header comment for
> pg_get_functiondef:
>
>  * Note: if you change the output format of this function, be careful not
>  * to break psql's rules (in \ef and \sf) for identifying the start of the
>  * function body.  To wit: the function body starts on a line that begins
>  * with "AS ", and no preceding line will look like that.
>
> Needless to say, the SQL-function-body patch has ignored this advice
> totally.  At the very least this comment needs to be adjusted, but
> I wonder if it's not telling us that \ef and/or \sf are broken.
>
>