Horton

Re: Fix \crosstabview to honor \pset display_true/display_false

David G. Johnston <david.g.johnston@gmail.com>

View thread View on postgr.es
From: "David G. Johnston" <david.g.johnston@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>, Álvaro Herrera <alvherre@kurilemu.de>, Bruce Momjian <bmomjian@gmail.com>
Date: 2026-06-19T15:51:22Z
Lists: pgsql-hackers 
On Thu, Jun 18, 2026 at 6:36 PM Chao Li <li.evan.chao@gmail.com> wrote:

> PFA v2: addressed David’s comments.
>

Looked a bit closer at printQuery this time; disliking that the if
condition has an awareness of the implementation of
printQueryOptDisplayValue since it lists !isnull and ftype != BOOLOID
explicitly.

How about not touching print.c at all with this patch, moving the
printQueryOptDisplayValue into crosstabview.c and leaving printQuery alone
since it is already correct?

David J.

P.S. When we do get to cleaning this up it seems annoying/odd that we
determine whether to apply numeric locale based upon whether the display
alignment for the column is right-aligned or not as opposed to the data
type of the value.

Commits

  1. Make crosstabview honor boolean/null display settings