Re: Fixes for missing schema qualifications

On Tue, Mar 13, 2018 at 5:11 PM, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:

> >>> +                                    "select pg_catalog.count(*) "
> >>> +                                    "from pg_catalog.pg_namespace
> where nspname = '%s'",
> >>
> >> This qualifies some functions, but it leaves plenty of unqualified
> operators.
>
> Oops. I meant:
>
> select pg_catalog.count(*) from pg_catalog.pg_namespace where
> pg_catalog.nameeq(nspname, '%s');
>
>
​I'd rather write that:

select [...] where nspname operator(pg_catalog.=) '%s'​

Introducing undocumented implementation functions to these queries is
undesirable; and besides, indexing and equivalence relies on operators and
not the underlying functions so there would be some risk of performance
issues if the functions were used directly.

David J.