Horton

Re: [PATCH] GROUP BY ALL

David G. Johnston <david.g.johnston@gmail.com>

View thread
From: "David G. Johnston" <david.g.johnston@gmail.com>
To: David Christensen <david@pgguru.net>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-07-22T21:33:57Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add GROUP BY ALL.

  2. Refactor to avoid code duplication in transformPLAssignStmt.

  3. Fix missed copying of groupDistinct in transformPLAssignStmt.

On Mon, Jul 22, 2024 at 1:55 PM David Christensen <david@pgguru.net> wrote:

> I see that there'd been some chatter but not a lot of discussion about
> a GROUP BY ALL feature/functionality.  There certainly is utility in
> such a construct IMHO.
>
> Still need some docs; just throwing this out there and getting some
> feedback.
>
>
I strongly dislike adding this feature.  I'd only consider supporting it if
it was part of the SQL standard.

Code is written once and read many times.  This feature caters to
the writer, not the reader.  And furthermore usage of this is prone to be
to the writer's detriment as well.

David J.