Re: Enable data checksums by default

Greg Sabino Mullane <htamfids@gmail.com>

From: Greg Sabino Mullane <htamfids@gmail.com>

To: Peter Eisentraut <peter@eisentraut.org>

Cc: Michael Paquier <michael@paquier.xyz>, Michael Banck <mbanck@gmx.net>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2024-08-23T13:55:58Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Avoid BufferGetLSNAtomic() calls during nbtree scans.
- e6eed40e4441 18.0 cited
doc PG 18 relnotes: Add incompatibility note about checksums now default
- 48814415d5aa 18.0 landed
Fix pg_upgrade's cross-version tests when old < 18
- 38c18710b37a 18.0 landed
initdb: Change default to using data checksums.
- 04bec894a04c 18.0 landed
Allow TAP tests to force checksums off when calling init()
- e7d0cf42b1ac 18.0 landed
initdb: Add new option "--no-data-checksums"
- 983a588e0b86 18.0 landed
Tweak docs to reduce possible impact of data checksums
- efd72a3d422b 18.0 landed

Attachments

v2-0004-Tweak-docs-to-reduce-possible-impact-of-data-checksums.patch (application/octet-stream) patch v2-0004
v2-0001-Add-new-initdb-argument-no-data-checksums-to-force-checksums-off.patch (application/octet-stream) patch v2-0001
v2-0003-Change-initdb-to-default-to-using-data-checksums.patch (application/octet-stream) patch v2-0003
v2-0002-Allow-tests-to-force-checksums-off-when-calling-init.patch (application/octet-stream) patch v2-0002

Rebased and reworked patches attached:

v2-0001-Add-new-initdb-argument-no-data-checksums-to-force-checksums-off.patch
- Adds --no-data-checksums to initdb.c, adjusts --help and sgml docs, adds
simple tests

v2-0002-Allow-tests-to-force-checksums-off-when-calling-init.patch
- Adjusts the Perl tests to use the new flag as needed

v2-0003-Change-initdb-to-default-to-using-data-checksums.patch
- Flips the boolean to true, adjusts the tests to match it, tweaks docs

v2-0004-Tweak-docs-to-reduce-possible-impact-of-data-checksums.patch
- Changes "noticeable" penalty to "small" penalty

Cheers,
Greg