Horton

Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE

Greg Sabino Mullane <htamfids@gmail.com>

View thread View on postgr.es
From: Greg Sabino Mullane <htamfids@gmail.com>
To: Guillaume Lelarge <guillaume@lelarge.info>
Cc: Robert Haas <robertmhaas@gmail.com>, Michael Christofides <michael@pgmustard.com>, David Rowley <dgrowleyml@gmail.com>, "David G. Johnston" <david.g.johnston@gmail.com>, Nikolay Samokhvalov <samokhvalov@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Date: 2024-11-20T00:12:37Z
Lists: pgsql-hackers 
I'm with Robert on this one. I'm a grudging +1 to buffers defaulting on,
and a strong -1 to all the other proposals. Guillaume, the patch looks
pretty good. I would like to see some of the example output have more than
just "shared hit" and "read" though: let's throw some "dirtied" and
"written" in there as well.

It defaults to <literal>TRUE</literal> when <literal>ANALYZE</literal> is
> also enabled. Otherwise, it defaults to <literal>FALSE</literal>.


Is that second sentence really needed? Because "BUFFERS ON" will never be
needed anymore (save as a no-op to allow the same explain queries to run
cross-version), and BUFFERS OFF outside of analyze is meaningless.

Cheers,
Greg

Commits

  1. Fix further fallout from EXPLAIN ANALYZE BUFFERS change

  2. Add missing BUFFERS OFF in regression tests, take 2

  3. Add missing BUFFERS OFF in select_into regression tests

  4. Enable BUFFERS with EXPLAIN ANALYZE by default