Horton

Re: tid_blockno() and tid_offset() accessor functions

Greg Sabino Mullane <htamfids@gmail.com>

View thread View on postgr.es
From: Greg Sabino Mullane <htamfids@gmail.com>
To: Tomas Vondra <tomas@vondra.me>
Cc: Alexandre Felipe <o.alexandre.felipe@gmail.com>, Ayush Tiwari <ayushtiwari.slg01@gmail.com>, pgsql-hackers@postgresql.org
Date: 2026-03-09T13:34:46Z
Lists: pgsql-hackers 
On Sun, Mar 8, 2026 at 3:31 PM Tomas Vondra <tomas@vondra.me> wrote:

> No opinion. For displaying the bogus TID value (like "(-1,0)") it's
> probably OK to show values that are a bit weird. If anything, we should
> be more careful on input, it's too late for tid_block() to decide what to
> do with an "impossible" TID value.
>

This one doesn't sit right with me. I think it's not too late. No reason
why tid_block cannot be stricter here than tid itself and complain. Other
than that, the patch looks good to me.


Cheers,
Greg

Commits

  1. Add tid_block() and tid_offset() accessor functions