Horton

Re: regdatabase

Greg Sabino Mullane <htamfids@gmail.com>

View thread
From: Greg Sabino Mullane <htamfids@gmail.com>
To: Ian Lawrence Barwick <barwick@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@postgresql.org
Date: 2025-05-07T14:29:43Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add new OID alias type regdatabase.

  2. pg_upgrade: Preserve database OIDs.

On Wed, May 7, 2025 at 4:55 AM Ian Lawrence Barwick <barwick@gmail.com>
wrote:

> Version which applies/builds against current HEAD attached. I haven't yet
> had a chance to look at the code beyond fixing it, however.
>

I too, have wanted this over the years, so +1 on the idea.

Quick review: nice patch, very thorough; applies cleanly; all tests pass;
acts as I would expect when testing manually.

Minor pgindent issue in the comment in src/backend/catalog/dependency.c

Would be nice to have test coverage of our special "single dash" case, e.g.

select regdatabase('-')::oid;
0

Cheers,
Greg

--
Crunchy Data - https://www.crunchydata.com
Enterprise Postgres Software Products & Tech Support