Horton
Menu

Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

Josh Kupershmidt <schmiddy@gmail.com>

View thread
From: Josh Kupershmidt <schmiddy@gmail.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, Satoshi Nagayasu <snaga@uptime.jp>, Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <bruce@momjian.us>, Dave Rolsky <autarch@urth.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2013-10-14T21:38:22Z
Lists: pgsql-bugs, pgsql-hackers 
On Thu, Oct 10, 2013 at 12:54 PM, Andrew Dunstan <andrew@dunslane.net> wrote:

> This thread seems to have gone cold, but I'm inclined to agree with Pavel.
> If the table doesn't exist, neither does the trigger, and the whole point of
> the 'IF EXISTS' variants is to provide the ability to issue DROP commands
> that don't fail if their target is missing.

+1 from me as well.

Also, Pavel, this patch is still listed as 'Needs Review' in the CF
app, but I haven't seen a response to the concerns in my last message.

Josh