Horton
Menu

Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

Josh Kupershmidt <schmiddy@gmail.com>

View thread
From: Josh Kupershmidt <schmiddy@gmail.com>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <bruce@momjian.us>, Dave Rolsky <autarch@urth.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2013-07-10T21:42:33Z
Lists: pgsql-bugs, pgsql-hackers 
On Tue, Jul 2, 2013 at 7:47 AM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
> Hello
>
> remastered patch
>
> still there is a issue with dependencies

Several of the issues from my last review [1] seem to still be present
in this patch, such as review notes #1 and #4.

And as discussed previously, I think that the --clean option belongs
solely with pg_restore for custom-format dumps. The way the patch
handles this is rather confusing, forcing the user to do:

  $  pg_dump -Fc --clean --if-exists --file=backup.dump ...
and then:
  $  pg_restore --clean ... backup.dump (without --if-exists)

to get the desired behavior.

Josh

[1] http://www.postgresql.org/message-id/CAK3UJRG__4=+f46XaMiqA80f_-BQhJcpFwyp8g8fpSPqj-JSzA@mail.gmail.com