Horton

Re: TRUNCATE on foreign table

Kazutaka Onishi <onishi@heterodb.com>

View thread View on postgr.es
From: Kazutaka Onishi <onishi@heterodb.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Kohei KaiGai <kaigai@heterodb.com>, Zhihong Yu <zyu@yugabyte.com>, Fujii Masao <masao.fujii@oss.nttdata.com>, Amit Langote <amitlangote09@gmail.com>, Ibrar Ahmed <ibrar.ahmad@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: 2021-04-07T03:30:00Z
Lists: pgsql-hackers

Attachments

> One minor thing - I think "mixtured" is not the
> correct word in "+-- partition table mixtured by table and foreign
> table". How about something like "+-- partitioned table with both
> local and foreign table as partitions"?

Sure. I've fixed this.

> The v15 patch basically looks good to me. I have no more comments.
Thank you for checking this many times.

> CF entry https://commitfest.postgresql.org/32/2972/ still says it's
> "waiting on author", do you want to change it to "needs review" if you
> have no open points left so that others can take a look at it?
Yes, please.

2021年4月7日(水) 10:15 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>:
>
> On Tue, Apr 6, 2021 at 10:15 PM Kazutaka Onishi <onishi@heterodb.com> wrote:
> > I've checked v15 patch with "make check-world" and confirmed this passed.
>
> Thanks for the patch. One minor thing - I think "mixtured" is not the
> correct word in "+-- partition table mixtured by table and foreign
> table". How about something like "+-- partitioned table with both
> local and foreign table as partitions"?
>
> The v15 patch basically looks good to me. I have no more comments.
>
> CF entry https://commitfest.postgresql.org/32/2972/ still says it's
> "waiting on author", do you want to change it to "needs review" if you
> have no open points left so that others can take a look at it?
>
> With Regards,
> Bharath Rupireddy.
> EnterpriseDB: http://www.enterprisedb.com

Commits

  1. doc: Review for "Allow TRUNCATE command to truncate foreign tables".

  2. Don't pass "ONLY" options specified in TRUNCATE to foreign data wrapper.

  3. Support tab-complete for TRUNCATE on foreign tables.

  4. Allow TRUNCATE command to truncate foreign tables.

  5. Add support for asynchronous execution.