Re: Removal of duplicate variable declarations in fe-connect.c

Haribabu Kommi <kommi.haribabu@gmail.com>

From: Haribabu Kommi <kommi.haribabu@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-02-22T07:50:18Z
Lists: pgsql-hackers
On Fri, Feb 22, 2019 at 3:22 PM Michael Paquier <michael@paquier.xyz> wrote:

> On Fri, Feb 22, 2019 at 11:33:17AM +1100, Haribabu Kommi wrote:
> > During the development of another feature, I found that same local
> > variables are declared twice.
> > IMO, there is no need of again declaring the local variables. Patch
> > attached.
>
> Indeed, fixed.  That's not a good practice, and each variable is
> assigned in its own block before getting used, so there is no
> overlap.
>

Thanks.

Regards,
Haribabu Kommi
Fujitsu Australia

Commits

  1. Remove duplicate variable declaration in fe-connect.c