Horton

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

Haribabu Kommi <kommi.haribabu@gmail.com>

View thread View on postgr.es
From: Haribabu Kommi <kommi.haribabu@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, sk@zsrv.org, Robert Haas <robertmhaas@gmail.com>, Fujii Masao <masao.fujii@gmail.com>, Ashutosh Sharma <ashu.coek88@gmail.com>, Euler Taveira <euler@timbira.com.br>, Pg Hackers <pgsql-hackers@postgresql.org>, Simon Riggs <simon@2ndquadrant.com>, Dave Page <dpage@pgadmin.org>
Date: 2018-07-09T05:57:58Z
Lists: pgsql-hackers

Attachments

On Mon, Jul 9, 2018 at 3:39 PM Haribabu Kommi <kommi.haribabu@gmail.com>
wrote:

>
> On Mon, Jul 9, 2018 at 12:24 PM Michael Paquier <michael@paquier.xyz>
> wrote:
>
>> On Fri, Jul 06, 2018 at 05:10:18PM -0400, Alvaro Herrera wrote:
>> > Ugh, it's true :-(
>> >
>> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=25fff40798fc4ac11a241bfd9ab0c45c085e2212#patch8
>> >
>> > Dave, Simon, any comments?
>>
>> The offending line:
>> contrib/pg_stat_statements/pg_stat_statements--1.4--1.5.sql:
>> GRANT EXECUTE ON FUNCTION pg_stat_statements_reset() TO pg_read_all_stats;
>>
>> This will need a new version bump down to REL_10_STABLE...
>>
>
> Hearing no objections, attached patch removes all permissions from PUBLIC
> as before this change went in. Or do we need to add command for revoke only
> from pg_read_all_stats?
>

Revoke all doesn't work, so patch updated with revoke from
pg_read_all_stats.

Regards,
Haribabu Kommi
Fujitsu Australia

Commits

  1. Extend pg_stat_statements_reset to reset statistics specific to a

  2. Default monitoring roles