Horton

Re: Pluggable Storage - Andres's take

Haribabu Kommi <kommi.haribabu@gmail.com>

View thread View on postgr.es
From: Haribabu Kommi <kommi.haribabu@gmail.com>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Andres Freund <andres@anarazel.de>, Alvaro Herrera <alvherre@2ndquadrant.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-10-18T03:28:01Z
Lists: pgsql-hackers 
On Tue, Oct 16, 2018 at 6:06 AM Alexander Korotkov <
a.korotkov@postgrespro.ru> wrote:

> Hi!
>
> On Wed, Oct 3, 2018 at 8:16 AM Andres Freund <andres@anarazel.de> wrote:
> > I've pushed an updated version, with a fair amount of pending changes,
> > and I hope all your pending (and not redundant, by our concurrent
> > development), patches merged.
>
> I'd like to also share some patches.  I've used current state of
> pluggable-zheap for the base of my patches.
>

Thanks for the review and patches.


>  * 0001-remove-extra-snapshot-functions.patch – removes
> snapshot_satisfiesUpdate() and snapshot_satisfiesVacuum() functions
> from tableam API.  snapshot_satisfiesUpdate() was unused completely.
> snapshot_satisfiesVacuum()  was used only in heap_copy_for_cluster().
> So, I've replaced it with direct heapam_satisfies_vacuum().
>

Thanks for the correction.


>  * 0002-add-costing-function-to-API.patch – adds function for costing
> sequential and table sample scan to tableam API.  zheap costing
> function are now copies of heap costing function.  This should be
> adjusted in future.


This patch misses the new *_cost.c files that are added specific cost
functions.


>   Estimation for heap lookup during index scans
> should be also pluggable, but not yet implemented (TODO).
>

Yes, Is it possible to use the same API that is added by above
patch?

Regards,
Haribabu Kommi
Fujitsu Australia

Commits

  1. Add default_table_access_method to postgresql.conf.sample.

  2. tableam: Avoid relying on relation size to determine validity of tids.

  3. tableam: Don't assume that every AM uses md.c style storage.

  4. Allow pg_class xid & multixid horizons to not be set.

  5. Fix slot type issue for fuzzy distance index scan over out-of-core table AM.

  6. tableam: comment and formatting fixes.

  7. table: docs: fix typos and grammar.

  8. tableam: basic documentation.

  9. Only allow heap in a number of contrib modules.

  10. tableam: Add table_finish_bulk_insert().

  11. tableam: sample scan.

  12. tableam: bitmap table scan.

  13. tableam: Move heap specific logic from estimate_rel_size below tableam.

  14. tableam: VACUUM and ANALYZE support.

  15. tableam: relation creation, VACUUM FULL/CLUSTER, SET TABLESPACE.

  16. tableam: Support for an index build's initial table scan(s).

  17. tableam: Add table_get_latest_tid, to wrap heap_get_latest_tid.

  18. tableam: Add helper for indexes to check if a corresponding table tuples exist.

  19. tableam: Add and use table_fetch_row_version().

  20. tableam: Use in CREATE TABLE AS and CREATE MATERIALIZED VIEW.

  21. Ensure sufficient alignment for ParallelTableScanDescData in BTShared.

  22. Don't reuse slots between root and partition in ON CONFLICT ... UPDATE.

  23. Use a virtual rather than a heap slot in two places where that suffices.

  24. Store tuples for EvalPlanQual in slots, rather than as HeapTuples.

  25. Use slots in trigger infrastructure, except for the actual invocation.

  26. Store table oid and tuple's tid in tuple slots directly.

  27. Allow to use HeapTupleData embedded in [Buffer]HeapTupleTableSlot.

  28. Add ExecStorePinnedBufferHeapTuple.

  29. Add ArchiveOpts to pass options to ArchiveEntry

  30. Rename RelationData.rd_amroutine to rd_indam.

  31. Rephrase references to "time qualification".

  32. Move remaining code from tqual.[ch] to heapam.h / heapam_visibility.c.

  33. Move generic snapshot related code from tqual.h to snapmgr.h.

  34. Remove superfluous tqual.h includes.

  35. Don't duplicate parallel seqscan shmem sizing logic in nbtree.

  36. Move vacuumlazy.c into access/heap.

  37. Support parallel bitmap heap scans.