Horton

Re: MSVC Build support with visual studio 2019

Haribabu Kommi <kommi.haribabu@gmail.com>

View thread View on postgr.es
From: Haribabu Kommi <kommi.haribabu@gmail.com>
To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-06-26T12:29:05Z
Lists: pgsql-hackers 
On Wed, 5 Jun 2019 at 17:22, Juan José Santamaría Flecha <
juanjo.santamaria@gmail.com> wrote:

>
> On Wed, May 29, 2019 at 10:30 AM Haribabu Kommi <kommi.haribabu@gmail.com>
> wrote:
>
>>
>> Updated patches are attached.
>>
>>
> All patches apply, build and pass tests. The patch
> '0001-support-building-with-visual-studio-2019_v10_to_v9.6_v3.patch'
> applies on version 9.5.
>
> Not sure if more review is needed before moving to 'ready for commite'r,
> but I have no more comments to make on current patches.
>

Thanks for the review. Yes, that patch applies till 9.5, it is my mistake
in naming the patch.

Regards,
Haribabu Kommi

Commits

  1. Add support for Visual Studio 2019 in build scripts

  2. Support building with Visual Studio 2017

  3. Require C99 (and thus MSCV 2013 upwards).