Horton

Re: How can end users know the cause of LR slot sync delays?

shveta malik <shveta.malik@gmail.com>

View thread
From: shveta malik <shveta.malik@gmail.com>
To: Shlok Kyal <shlok.kyal.oss@gmail.com>
Cc: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Ashutosh Sharma <ashu.coek88@gmail.com>, shveta malik <shveta.malik@gmail.com>
Date: 2025-11-27T05:12:05Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Rename column slotsync_skip_at to slotsync_last_skip.

  2. Add slotsync_skip_reason column to pg_replication_slots view.

  3. Fix test failure caused by commit 76b78721ca.

  4. Fix a BF failure caused by commit 76b78721ca.

  5. Add slotsync skip statistics.

On Thu, Nov 27, 2025 at 9:25 AM Shlok Kyal <shlok.kyal.oss@gmail.com> wrote:
>
> I have made some minor changes in documentation and comments. Attached
> the updated patch.
>

1)
<literal>NULL</literal> if
       slot synchronization is successful.

We shall add 'It is' to maintain continuity as the previous sentence has it.

2)
Related to previous patch: pgstat_report_replslotsync() currently has
sanity check Assert(SlotIsLogical(slot));
Instead, shall we have Assert(slot->synced)? It will implicitly ensure
that the slot is logical, plus it is important to check that we are
updating stats of synced slot only.

thanks
Shveta