Horton

Re: Correction in doc of failover ready steps

shveta malik <shveta.malik@gmail.com>

View thread View on postgr.es
From: shveta malik <shveta.malik@gmail.com>
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, "pgsql-docs@lists.postgresql.org" <pgsql-docs@lists.postgresql.org>, shveta malik <shveta.malik@gmail.com>
Date: 2024-07-24T04:10:49Z
Lists: pgsql-docs

Attachments

On Wed, Jul 24, 2024 at 9:02 AM Zhijie Hou (Fujitsu)
<houzj.fnst@fujitsu.com> wrote:
>
> Thanks for the patch.
>
> Here is one comment:
>
> The second query has a condition 'WHERE slot_name IS NOT NULL', but I
> think it belongs to the first query. Because the slot_name of second query
> is built by CONCAT() which means it should be valid, while the first query's
> subslotname could be NULL if user executed ALTER SUB SET (slot_name = NONE).
>

Thanks for pointing it out. Please find a new patch with this change.

Also corrected the commit message in this patch.

thanks
Shveta

Commits

  1. Doc: Fix the mistakes in the subscription's failover option.