Horton

Re: Conflict detection for update_deleted in logical replication

shveta malik <shveta.malik@gmail.com>

View thread View on postgr.es
From: shveta malik <shveta.malik@gmail.com>
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, vignesh C <vignesh21@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, shveta malik <shveta.malik@gmail.com>
Date: 2025-06-27T08:07:20Z
Lists: pgsql-hackers 
On Fri, Jun 27, 2025 at 7:58 AM Zhijie Hou (Fujitsu)
<houzj.fnst@fujitsu.com> wrote:
>
> On Thu, Jun 26, 2025 at 4:28 PM shveta malik wrote:
> >
> > On Thu, Jun 26, 2025 at 8:31 AM Zhijie Hou (Fujitsu)
> > <houzj.fnst@fujitsu.com> wrote:
> > >
> > > Thanks for the comments. All of them look good to me and
> > > have been addressed in V42.
> > >
> >
> > Thank You for the patches. Few comments.
> >
> > t/035_conflicts.pl:
> >
> > 1)
> > Both the subscriptions subname_BA and subname_AB have rci enabled
> > during CREATE sub itself. And later in the second test, we are trying
> > to enable rci of subname_AB  to test WARNING and NOTICE, but rci is
> > already enabled. Shall we have one CREATE sub with rci enabled while
> > another CREATE sub with default rci. And then we try to enable rci of
> > the second sub later and check pg_conflict_detection slot has been
> > created once we enabled rci. This way, it will cover more scenarios.
>
> Agreed and changed as suggested. I removed the test for WARNING since the
> message is the same as the NOITCE and it seems not worthwhile to disable
> the subscription again to verify one message.
>

Okay. Agreed.

patch001 looks good to me now.

thanks
Shveta

Commits

  1. Fix intermittent BF failures in 035_conflicts.

  2. Resume conflict-relevant data retention automatically.

  3. Fix intermittent test failure introduced in 6456c6e2c4.

  4. Fix Coverity issue reported in commit a850be2fe.

  5. Add test to prevent premature removal of conflict-relevant data.

  6. Post-commit review fixes for 228c370868.

  7. Add max_retention_duration option to subscriptions.

  8. Detect and report update_deleted conflicts.

  9. Preserve conflict-relevant data during logical replication.

  10. Integrate FullTransactionIds deeper into two-phase code

  11. Improve checks for GUC recovery_target_timeline

  12. Prevent excessive delays before launching new logrep workers.

  13. Keep WAL segments by slot's last saved restart LSN

  14. Rework some code handling pg_subscription data in psql and pg_dump

  15. Use generateClonedIndexStmt to propagate CREATE INDEX to partitions.