Horton

Re: Support logical replication of DDLs

shveta malik <shveta.malik@gmail.com>

View thread
From: shveta malik <shveta.malik@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Amit Kapila <amit.kapila16@gmail.com>, "Wei Wang (Fujitsu)" <wangw.fnst@fujitsu.com>, "Yu Shi (Fujitsu)" <shiy.fnst@fujitsu.com>, vignesh C <vignesh21@gmail.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Ajin Cherian <itsajin@gmail.com>, Runqi Tian <runqidev@gmail.com>, Peter Smith <smithpb2250@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, li jie <ggysxcq@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Masahiko Sawada <sawada.mshk@gmail.com>, Japin Li <japinli@hotmail.com>, rajesh singarapu <rajesh.rs0541@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Zheng Li <zhengli10@gmail.com>, shveta malik <shveta.malik@gmail.com>
Date: 2023-06-16T10:31:37Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add a run_as_owner option to subscriptions.

  2. Refactor pgoutput_change().

  3. Print the correct aliases for DML target tables in ruleutils.

  4. Fix object identity string for transforms

  5. Add grantable MAINTAIN privilege and pg_maintain role.

  6. Get rid of recursion-marker values in enum AlterTableType

  7. Release cache tuple when no longer needed

  8. Empty search_path in logical replication apply worker and walsender.

  9. Refactor format_type APIs to be more modular

  10. Use wrappers of PG_DETOAST_DATUM_PACKED() more.

Attachments

On Wed, Jun 14, 2023 at 3:26 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Jun 13, 2023 at 06:49:42PM +0530, Amit Kapila wrote:
> > We have to choose one of the approaches between 0001 and 0008. I feel
> > we don't need an intermediate ObjTree representation as that adds
> > overhead and an additional layer which is not required. As mentioned
> > in my previous email I think as a first step we should merge 0001 and
> > 0008 and avoid having an additional ObjTree layer unless you or others
> > feel we need it. I think that will reduce the overall patch size and
> > help us to focus on one of the approaches.
>
> Similar impression here.  I found ObjTree actually confusing compared
> to the JSON blobs generated.
>

+1

Please find the new set of patches. It has below changes:

Patch-set Structure related changes to make it more organised:
1) Object-tree removal code (patch 0008 earlier) is now merged to
patch 0001. Now there is no reference of object-tree in the code.
2) Subscription tap-test for DDL Replication (patch 0006 earlier) is
now merged to patch 0003 (DDL Replication one), as it was a single
file change and thus seems more apt to be part of the DDL-Rep patch.
3) test_ddl_deparse_regress module (patch 0004 earlier) is now pulled
out for the time being.

Rest of the changes:
1) CTAS and SELECT INTO support removal. Initial draft aims to support
create,drop and alter-table first.
2) Doc compilation issue fix for 'doc/src/sgml/logical-replication.sgml'.
3) Verbose option removal. Current patch now WAL logs only the
information needed to construct the original DDL statement. Missing
clauses are not part of the final DDL string. I will upload support
for 'expanded' on/off in the next version.
4) Some code refactoring and optimization.

With these changes, I hope the patch-set is somewhat easier to review.

thanks
Shveta