Re: Logical Replication of sequences

shveta malik <shveta.malik@gmail.com>

From: shveta malik <shveta.malik@gmail.com>

To: vignesh C <vignesh21@gmail.com>

Cc: Nisha Moond <nisha.moond412@gmail.com>, Peter Smith <smithpb2250@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Euler Taveira <euler@eulerto.com>, Michael Paquier <michael@paquier.xyz>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, "Jonathan S. Katz" <jkatz@postgresql.org>, shveta malik <shveta.malik@gmail.com>

Date: 2025-06-02T09:24:34Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Doc: Add documentation for sequence synchronization.
- 55cefadde874 19 (unreleased) landed
Remove unused assignment in CREATE PUBLICATION grammar.
- bfb7419b0bbe 19 (unreleased) landed
Add seq_sync_error_count to subscription statistics.
- f6a4c498dcf6 19 (unreleased) landed
Fix few issues in commit 5509055d69.
- 5a4eba558aa7 19 (unreleased) landed
Add sequence synchronization for logical replication.
- 5509055d6956 19 (unreleased) landed
Add worker type argument to logical replication worker functions.
- 3e8e05596a02 19 (unreleased) landed
Introduce "REFRESH SEQUENCES" for subscriptions.
- f0b3573c3aac 19 (unreleased) landed
Refactor logical worker synchronization code into a separate file.
- 41c674d2e31e 19 (unreleased) landed
Standardize use of REFRESH PUBLICATION in code and messages.
- 2436b8c047ff 19 (unreleased) landed
Add "ALL SEQUENCES" support to publications.
- 96b378497346 19 (unreleased) landed
Expose sequence page LSN via pg_get_sequence_data.
- b93172ca59f4 19 (unreleased) landed
Resume conflict-relevant data retention automatically.
- 0d48d393d465 19 (unreleased) cited
Post-commit review fixes for 228c370868.
- 1f7e9ba3ac4e 19 (unreleased) cited
Generate GUC tables from .dat file
- 63599896545c 19 (unreleased) cited

On Thu, May 29, 2025 at 8:09 PM vignesh C <vignesh21@gmail.com> wrote:
> These comments are handled in the attached v2025029 version patch.
>

Thanks for the patches. I am still reviewing but please find few comments:

1)
     <para>
      Only persistent sequences are included in the publication. Temporary
      sequences are excluded from the publication.
     </para>

We shall mention UNLOGGED sequences as well along with TEMP sequences.

2)
Why do we have GetAllSequencesPublicationRelations() in patch002? It
is used only in patch004. Same thing with is_publishable_class()
change.

3)
process_syncing_tables_for_sync() is renamed to ProcessSyncingTablesForSync()
process_syncing_tables_for_apply() is renamed to ProcessSyncingTablesForApply()
process_syncing_tables() is renamed to SyncProcessRelations()

Why have we named it SyncProcessRelations and not
ProcessSyncingRelations? Is it because we want to start a name with
'Sync' in order to have file name initials? But do not see other files
following it. IMO, ProcessSyncingTables looks more familiar and apt
over SyncProcessRelations. Same with 'SyncFinishWorker'.
FinishSyncWorker instead looks better. Thoughts?

4)
postgres=# CREATE publication pub1 for sequences;
ERROR:  invalid publication object list
LINE 1: CREATE publication pub1 for sequences;
                                    ^
DETAIL:  One of TABLE or TABLES IN SCHEMA must be specified before a
standalone table or schema name.

Do you think we shall mention sequence specific info as well in DETAIL now?

thanks
Shveta