Re: Disallow altering invalidated replication slots

shveta malik <shveta.malik@gmail.com>

From: shveta malik <shveta.malik@gmail.com>

To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, shveta malik <shveta.malik@gmail.com>

Date: 2024-09-10T05:07:19Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Prohibit altering invalidated replication slots.
- 4d8489f4f1fa 18.0 landed

On Tue, Sep 10, 2024 at 12:11 AM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> Hi,
>
> ALTER_REPLICATION_SLOT on invalidated replication slots is unnecessary
> as there is no way to get the invalidated (logical) slot to work.
> Please find the patch to add an error in such cases. Relevant
> discussion is at [1].
>
> Thoughts?
>

+1 on the idea.

+ errmsg("cannot alter replication slot \"%s\"", name),
+ errdetail("This replication slot was invalidated due to \"%s\".",

Maybe we shall have: "This slot has been invalidated due to ..."
This is similar to all other occurrences where such errors are raised,
see logical.c for instance.

thanks
Shveta