Re: Logical Replication of sequences

shveta malik <shveta.malik@gmail.com>

From: shveta malik <shveta.malik@gmail.com>

To: vignesh C <vignesh21@gmail.com>

Cc: Chao Li <li.evan.chao@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Dilip Kumar <dilipbalaut@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Euler Taveira <euler@eulerto.com>, Michael Paquier <michael@paquier.xyz>, "Jonathan S. Katz" <jkatz@postgresql.org>, Peter Smith <smithpb2250@gmail.com>, shveta malik <shveta.malik@gmail.com>

Date: 2025-10-29T09:08:26Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Doc: Add documentation for sequence synchronization.
- 55cefadde874 19 (unreleased) landed
Remove unused assignment in CREATE PUBLICATION grammar.
- bfb7419b0bbe 19 (unreleased) landed
Add seq_sync_error_count to subscription statistics.
- f6a4c498dcf6 19 (unreleased) landed
Fix few issues in commit 5509055d69.
- 5a4eba558aa7 19 (unreleased) landed
Add sequence synchronization for logical replication.
- 5509055d6956 19 (unreleased) landed
Add worker type argument to logical replication worker functions.
- 3e8e05596a02 19 (unreleased) landed
Introduce "REFRESH SEQUENCES" for subscriptions.
- f0b3573c3aac 19 (unreleased) landed
Refactor logical worker synchronization code into a separate file.
- 41c674d2e31e 19 (unreleased) landed
Standardize use of REFRESH PUBLICATION in code and messages.
- 2436b8c047ff 19 (unreleased) landed
Add "ALL SEQUENCES" support to publications.
- 96b378497346 19 (unreleased) landed
Expose sequence page LSN via pg_get_sequence_data.
- b93172ca59f4 19 (unreleased) landed
Resume conflict-relevant data retention automatically.
- 0d48d393d465 19 (unreleased) cited
Post-commit review fixes for 228c370868.
- 1f7e9ba3ac4e 19 (unreleased) cited
Generate GUC tables from .dat file
- 63599896545c 19 (unreleased) cited

Please find few trivial comments on 001:

1)
+ * The sequencesync worker is responsible for synchronizing sequences marked in
+ * pg_subscription_rel.

Shall we tweak it slightly to say:
'A single sequencesync worker is responsible for synchronizing all
sequences marked in pg_subscription_rel.'

I feel the fact that there is 'single seq-sync worker' is important to
mention in the file-header.

2)
sequencesync.c compiles without this:

#include "replication/logicallauncher.h"

3)
Can we improve FetchRelationStates() slightly? Currently for sequence,
it has an output parameter but for tables, it has return value, which
looks odd to me.

4)
AllTablesyncsReady() has changed the name of the variable from
has_subrels to has_tables which looks better. Do we need a similar
change in  HasSubscriptionTablesCached as well?

5)
+is($result, '100|0|t', 'REFRESH PUBLICATION does not sync existing sequence');

+is($result, '1|0|f',
+ 'REFRESH SEQUENCES will not sync newly published sequence');

One has 'does not' while the other has 'will not'. Can we make both the same?

thanks
Shveta