Re: Support EXCEPT for ALL SEQUENCES publications

On Tue, Jun 23, 2026 at 3:03 PM Shlok Kyal <shlok.kyal.oss@gmail.com> wrote:
>
>
> I have addressed the comments and attached the updated v12 patch
>

Thanks Shlok. I have resumed review of this thread. A few comment for 001:


1)

Can we make 'opt_sequence' (SEQUENCE | EMPTY) similar to opt_table and
then use it here. It will be similar to pub_except_tbl_list and easier
to understand.

2)
getPublications:
+ if (relkind == RELKIND_SEQUENCE)
+ simple_ptr_list_append(&pubinfo[i].except_sequences, tbinfo);
+ else
+ simple_ptr_list_append(&pubinfo[i].except_tables, tbinfo);

Can we do this:
if (relkind == RELKIND_SEQUENCE)
    ...
else if (relkind == RELKIND_RELATION ||
         relkind == RELKIND_PARTITIONED_TABLE)
    ...
else
    Assert(false);


3)
describeOneTableDetails:
+ * Skip entries where this sequence appears in the publication's
+ * EXCEPT list.
+ *
+ * For a FOR ALL SEQUENCES publication, pg_publication_rel
+ * contains entries only for sequences specified in the EXCEPT
+ * clause, so there is no need to check pr.prexcept explicitly.

My personal preference will be to have pr.prexcept check in the query
and get rid of this comment.

4)
- char    *footers[3] = {NULL, NULL, NULL};
+ char    *footers[4] = {NULL, NULL, NULL, NULL};

Is this intentional? We are using only 3 of these though.

thanks
Shveta