Re: How can end users know the cause of LR slot sync delays?

shveta malik <shveta.malik@gmail.com>

From: shveta malik <shveta.malik@gmail.com>

To: Shlok Kyal <shlok.kyal.oss@gmail.com>

Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Ashutosh Sharma <ashu.coek88@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, shveta malik <shveta.malik@gmail.com>

Date: 2025-11-24T05:53:56Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Rename column slotsync_skip_at to slotsync_last_skip.
- 5db6a344abc2 19 (unreleased) landed
Add slotsync_skip_reason column to pg_replication_slots view.
- e68b6adad96d 19 (unreleased) landed
Fix test failure caused by commit 76b78721ca.
- e3e787ca0234 19 (unreleased) landed
Fix a BF failure caused by commit 76b78721ca.
- 3df4df53b06d 19 (unreleased) landed
Add slotsync skip statistics.
- 76b78721ca49 19 (unreleased) landed

On Fri, Nov 21, 2025 at 6:21 PM Shlok Kyal <shlok.kyal.oss@gmail.com> wrote:
>
> The Cbot complained that it was not able to build the docs. I have
> fixed it and attached the latest patch.
>

Few comments on 001:

1)
In pgstat_report_replslotsync_skip(), shall we have a sanity check to
ensure that slot is logical and function is called on a
standby(RecoveryInProgress)?

2)
In update_and_persist_local_synced_slot(), we have comments at 3
places to indicate that stats are updated in some other
function.Instead, shall we have a generic comment in the header of
this function?

3)
Shall we have the test moved to the existing file
040_standby_failover_slots_sync?

4)
We should be able to make test work without injection point, please
try for that. Also it should be enough to test stats for one flow
instead of multiple flows.

thanks
Shveta