Horton

Re: Replication slot is not able to sync up

shveta malik <shveta.malik@gmail.com>

View thread
From: shveta malik <shveta.malik@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Suraj Kharage <suraj.kharage@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, shveta malik <shveta.malik@gmail.com>
Date: 2025-06-16T03:56:54Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Improve log messages and docs for slot synchronization.

Attachments

On Sat, Jun 14, 2025 at 11:08 AM Amit Kapila <amit.kapila16@gmail.com> wrote:

> > I feel WARNING and CAUTION markups could be a little strong for the
> > concerned case. Such markups are generally used when there is a
> > side-effect involved with the usage. But in our case, there is no such
> > side-effect with the API. At max it may fail without harming the
> > system and will succeed in the next invocation. But I also feel that
> > such sections catch user attention. Thus if needed, we can have a NOTE
> > section to convey the recommended way of slot synchronization.
> >
>
> I think NOTE is fine for API in this case, but we can mention that the
> API is more prone to get the synchronization failure message, as you
> have shown in the patch. It would also be better to briefly explain in
> user terms why the API is more prone to such a failure.
>

Thanks Peter and Amit for feedback. I have updated the patch.

thanks
Shveta