Horton
Menu

Re: [Proposal] Adding Log File Capability to pg_createsubscriber

shveta malik <shveta.malik@gmail.com>

View thread
From: shveta malik <shveta.malik@gmail.com>
To: Gyan Sreejith <gyan.sreejith@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Euler Taveira <euler@eulerto.com>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Peter Smith <smithpb2250@gmail.com>, shveta malik <shveta.malik@gmail.com>
Date: 2026-03-17T06:05:53Z
Lists: pgsql-hackers 
On Mon, Mar 16, 2026 at 4:53 AM Gyan Sreejith <gyan.sreejith@gmail.com> wrote:
>
>
> Thank you! I have attached the changes.

Thank You for the patch.

1)
 I observed that when we give both --verbose and --logdir options, it
skips verbose and only dumps logs to logdir. Is this intentional?

I don't see any other postgres command with both the options provided
and thus cannot compare the behaviour. But IMO, if the user has
explicitly given both options, we should dump the log on both (stdout
and logfile). Thoughts?  (Apologies if this has already been discussed
and I missed it.)

2)
I noticed a minor difference when running the command with both
--verbose and --logdir, depending on the order in which they are
specified.

If --verbose is specified first, I see the following message on the console:
pg_createsubscriber: directory ../../pg_createsub/20260317T112204.848 created

But if --logdir is specified first, this message does not appear on
the console. Is this behavior intentional?

thanks
Shveta

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_createsubscriber: Don't use MAXPGPATH

  2. pg_createsubscriber: Remove separate logfile_open() function

  3. pg_createsubscriber: Use logging.c log file callback

  4. Add log file support to logging.c

  5. pg_createsubscriber: Add -l/--logdir option to redirect output to files.

  6. pg_createsubscriber: Introduce module-specific logging functions.

  7. Fix another buglet in archive_waldump.c.