Horton

Re: [Patch] add new parameter to pg_replication_origin_session_setup

shveta malik <shveta.malik@gmail.com>

View thread View on postgr.es
From: shveta malik <shveta.malik@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Doruk Yilmaz <doruk@mixrank.com>, shveta malik <shveta.malik@gmail.com>
Date: 2026-03-25T09:33:27Z
Lists: pgsql-hackers 
On Wed, Mar 25, 2026 at 1:51 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, Feb 11, 2026 at 5:09 PM shveta malik <shveta.malik@gmail.com> wrote:
> >
> > On Wed, Feb 11, 2026 at 3:41 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > >
> > >
> > > I see your point but one advantage with the proposed code change is
> > > that it started to appear that we can extend this part of code easily
> > > in the future as it separates most of the handling related to when a
> > > user has given acquired_by parameter's value as zero and non-zero.
> >
> > Okay, yes. So I am okay with it. The slight change I suggested (if to
> > else-if) and a comment will make it more clean.
> >
>
> I have tried to address both your suggestions in the attached. See, if
> this looks okay to you now?
>

LGTM now, thanks!

thanks
Shveta

Commits

  1. Refactor replorigin_session_setup() for better readability.

  2. Prevent unintended dropping of active replication origins.

  3. Add optional pid parameter to pg_replication_origin_session_setup().