Horton

Re: Add contrib/pg_logicalsnapinspect

shveta malik <shveta.malik@gmail.com>

View thread
From: shveta malik <shveta.malik@gmail.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, pgsql-hackers@lists.postgresql.org, shveta malik <shveta.malik@gmail.com>
Date: 2024-09-26T03:27:22Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix indentation issue

  2. pg_logicalinspect: Stabilize isolation tests.

  3. Add contrib/pg_logicalinspect.

  4. Move SnapBuild and SnapBuildOnDisk structs to snapshot_internal.h.

On Wed, Sep 25, 2024 at 11:01 PM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> Hi,
>
> On Wed, Sep 25, 2024 at 11:23:17AM +0530, shveta malik wrote:
> > + OUT catchange_xip xid[]
> >
> > One question, what is xid datatype, is it too int8? Sorry, could not
> > find the correct doc.
>
> I think that we can get the answer from pg_type:
>
> postgres=# select typname,typlen from pg_type where typname = 'xid';
>  typname | typlen
> ---------+--------
>  xid     |      4
> (1 row)
>
> > Since we are getting uint32 in Int64, this also needs to be accordingly.
>
> I think the way it is currently done is fine: we're dealing with TransactionId
> (and not with FullTransactionId). So, the Int64GetDatum() output would still
> stay in the "xid" range. Keeping xid in the .sql makes it clear that we are
> dealing with transaction ID.
>

Okay, got it. The 'xid' usage is fine then.

thanks
Shveta