Re: Fix tab completion after EXCEPT (...) in IMPORT FOREIGN SCHEMA

On Wed, Apr 15, 2026 at 8:45 PM vignesh C <vignesh21@gmail.com> wrote:
>
> Hi all,
>
> While reviewing tab completion behavior, I noticed an issue after
> EXCEPT (...) support was added to CREATE PUBLICATION.
> Currently, after typing:
> IMPORT FOREIGN SCHEMA public EXCEPT (t1)
>
> psql correctly suggests FROM SERVER. However, the existing completion
> rule uses a generic:
> TailMatches("EXCEPT", "(*)")
>
> Previously this was safe because no other command used EXCEPT (...).
> Now that CREATE PUBLICATION also supports EXCEPT (...), the same rule
> can incorrectly match publication commands and suggest FROM SERVER
> there as well.
>
> The attached patch fixes this by restricting the EXCEPT (...) path to
> IMPORT FOREIGN SCHEMA using HeadMatches(), while preserving the
> existing LIMIT TO (...) behavior.
>

I can reproduce the problem without the patch. The patch looks good to me.

thanks
Shveta