Horton

Re: Logical Replication of sequences

shveta malik <shveta.malik@gmail.com>

View thread
From: shveta malik <shveta.malik@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, Chao Li <li.evan.chao@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Shinya Kato <shinya11.kato@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Dilip Kumar <dilipbalaut@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Euler Taveira <euler@eulerto.com>, Michael Paquier <michael@paquier.xyz>, "Jonathan S. Katz" <jkatz@postgresql.org>, shveta malik <shveta.malik@gmail.com>
Date: 2025-12-22T04:50:30Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Doc: Add documentation for sequence synchronization.

  2. Remove unused assignment in CREATE PUBLICATION grammar.

  3. Add seq_sync_error_count to subscription statistics.

  4. Fix few issues in commit 5509055d69.

  5. Add sequence synchronization for logical replication.

  6. Add worker type argument to logical replication worker functions.

  7. Introduce "REFRESH SEQUENCES" for subscriptions.

  8. Refactor logical worker synchronization code into a separate file.

  9. Standardize use of REFRESH PUBLICATION in code and messages.

  10. Add "ALL SEQUENCES" support to publications.

  11. Expose sequence page LSN via pg_get_sequence_data.

  12. Resume conflict-relevant data retention automatically.

  13. Post-commit review fixes for 228c370868.

  14. Generate GUC tables from .dat file

On Mon, Dec 22, 2025 at 4:41 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Vignesh,
>
> A couple of review comments for v2-0001
>
> ======
> src/backend/catalog/pg_publication.c
>
> pg_get_publication_tables:
>
> 1.
>   if (pub_elem->alltables)
>   pub_elem_tables = GetAllPublicationRelations(RELKIND_RELATION,
>   pub_elem->pubviaroot);
> - else
> + else if (!pub_elem->allsequences)
>   {
>   List    *relids,
>      *schemarelids;
> @@ -1203,8 +1203,13 @@ pg_get_publication_tables(PG_FUNCTION_ARGS)
>   table_infos = lappend(table_infos, table_info);
>   }
>
> - /* At least one publication is using publish_via_partition_root. */
> - if (pub_elem->pubviaroot)
> + /*
> + * At least one publication is using publish_via_partition_root.
> + * Skip sequences only publications, as publish_via_partition_root
> + * is applicable only to table publications.
> + */
> + if (pub_elem->pubviaroot && !PUB_HAS_SEQUENCES_ONLY(pub_elem->allsequences,
> + pub_elem->alltables))
>   viaroot = true;
>
> Won't it be simpler to check this up-front and then just 'continue'?
> Then you wouldn't have to handle "sequence only" for the rest of the
> loop logic.

+1. It will simplify the code.

> e.g.
>
> pub_elem = ...
>
> /* Skip this publication if no TABLES are published. */
> if (PUB_HAS_SEQUENCES_ONLY(pub_elem->allsequences, pub_elem->alltables)
>   continue;
>
> if (pub_elem->alltables)
>   ...
> else
>   ...
>
> ======
> src/backend/commands/publicationcmds.c
>
> 2.
> - if (!pubform->puballtables && publish_via_partition_root_given &&
> - !publish_via_partition_root)
> + if (!pubform->puballtables && !pubform->puballsequences &&
> + publish_via_partition_root_given && !publish_via_partition_root)
>
> I felt this modified condition ought to be expressed as:
>
> if (!PUB_HAS_SEQUENCES_ONLY(...) && <original condition>
>
> ======
> Kind Regards,
> Peter Smith.
> Fujitsu Australia