Horton

Re: [Proposal] Global temporary tables

Andrew Bille <andrewbille@gmail.com>

View thread
From: Andrew Bille <andrewbille@gmail.com>
To: wenjing <wenjing@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, Tony Zhu <Tony.zhu@ww-it.cn>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-01-10T09:17:23Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. PageAddItemExtended(): Add LP_UNUSED assertion.

  2. Remove temporary files after backend crash

  3. Fix comment in indexing.c

  4. Fix failure to ignore leftover temp tables after a server crash.

Hi!

I could not detect crashes with your last patch, so I think the patch is
ready for a review.
Please, also consider fixing error messages, as existing ones don't follow
message writing guidelines.
https://www.postgresql.org/docs/14/error-style-guide.html

Regards, Andrew

On Thu, Dec 23, 2021 at 7:36 PM wenjing <wjzeng2012@gmail.com> wrote:

>
>
> Andrew Bille <andrewbille@gmail.com> 于2021年12月21日周二 14:00写道：
>
>> Hi!
>> Thanks for new patches.
>> Yet another crash reproduced on master with v63 patches:
>>
>> CREATE TABLESPACE ts LOCATION '/tmp/ts';
>> CREATE GLOBAL TEMP TABLE tbl (num1 bigint);
>> INSERT INTO tbl (num1) values (1);
>> CREATE INDEX tbl_idx ON tbl (num1);
>> REINDEX (TABLESPACE ts) TABLE tbl;
>>
> This is a feature made in PG14 that supports reindex change tablespaces.
> Thank you for pointing that out and I fixed it in v64.
> Waiting for your feedback.
>