Horton

Re: Added schema level support for publication.

Greg Nancarrow <gregn4422@gmail.com>

View thread View on postgr.es
From: Greg Nancarrow <gregn4422@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, Peter Smith <smithpb2250@gmail.com>, Ajin Cherian <itsajin@gmail.com>, Rahila Syed <rahilasyed90@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: 2021-10-29T02:46:00Z
Lists: pgsql-hackers 
On Thu, Oct 28, 2021 at 3:25 PM vignesh C <vignesh21@gmail.com> wrote:
>
> Thanks for committing the patch, please find the remaining patches attached.

A few comments on the v48-0002 patch:

(1) The quoting of TABLE/SCHEMA looks a bit odd in the patch comment

(2) src/backend/catalog/system_views.sq
ON should be capitalized in the following line:
+    JOIN pg_catalog.pg_namespace N on N.oid = S.pnnspid

(3) Some basic tests should be added for this in the publication tests.


Regards,
Greg Nancarrow
Fujitsu Australia

Commits

  1. Include schema/table publications even with exclude options in dump.

  2. Rename some enums to use TABLE instead of REL.

  3. Add tap tests for the schema publications.

  4. Allow publishing the tables of schema.

  5. In pg_dump, use simplehash.h to look up dumpable objects by OID.