Horton

Re: Re[3]: On login trigger: take three

Greg Nancarrow <gregn4422@gmail.com>

View thread View on postgr.es
From: Greg Nancarrow <gregn4422@gmail.com>
To: Ivan Panchenko <wao@mail.ru>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Amit Kapila <amit.kapila16@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Konstantin Knizhnik <k.knizhnik@postgrespro.ru>
Date: 2021-06-03T03:05:50Z
Lists: pgsql-hackers

Attachments

On Fri, May 21, 2021 at 2:46 PM Greg Nancarrow <gregn4422@gmail.com> wrote:
>
> On Thu, May 20, 2021 at 2:45 PM Ivan Panchenko <wao@mail.ru> wrote:
> >
> > I have upgraded the patch for the 14th version.
> >
>
> I have some feedback on the patch:
>

I've attached an updated version of the patch.
I've applied my review comments and done a bit more tidying up of
documentation and comments.
Also, I found that the previously-posted patch was broken by
snapshot-handling changes in commit 84f5c290 (with patch applied,
resulting in a coredump during regression tests) so I've added a fix
for that too.

Regards,
Greg Nancarrow
Fujitsu Australia

Commits

  1. Fix some typos in event trigger docs

  2. Use heap_inplace_update() to unset pg_database.dathasloginevt

  3. Remove the flaky check in event_trigger_login regression test

  4. Fix instable 006_login_trigger.pl test

  5. Add support event triggers on authenticated login

  6. Add GUC for temporarily disabling event triggers

  7. Fix typo in reference to __FreeBSD__.

  8. Restore robustness of TAP tests that wait for postmaster restart.

  9. Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.