Horton

Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values

Greg Nancarrow <gregn4422@gmail.com>

View thread View on postgr.es
From: Greg Nancarrow <gregn4422@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-07-12T04:48:06Z
Lists: pgsql-hackers 
On Mon, Jul 12, 2021 at 2:26 PM David Rowley <dgrowleyml@gmail.com> wrote:
>
> > It seems strange to add a comment to explain why it's there. If we're
> > going to the trouble of doing that, then we should just remove it and
> > add a very small comment to mention why INT8 sequences don't need to
> > be checked.
>
> Any thoughts on this, Greg?
>

The patch LGTM (it's the same as my original patch but with short comments).

Regards,
Greg Nancarrow
Fujitsu Australia

Commits

  1. Remove useless range checks on INT8 sequences