Re: Data is copied twice when specifying both child and parent table in publication
Greg Nancarrow <gregn4422@gmail.com>
From: Greg Nancarrow <gregn4422@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Amit Langote <amitlangote09@gmail.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
Dilip Kumar <dilipbalaut@gmail.com>
Date: 2021-11-04T06:53:24Z
Lists: pgsql-hackers
On Thu, Nov 4, 2021 at 3:13 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > On further thinking about this, I think we should define the behavior > of replication among partitioned (on the publisher) and > non-partitioned (on the subscriber) tables a bit more clearly. > > - If the "publish_via_partition_root" is set for a publication then we > can always replicate to the table with the same name as the root table > in publisher. > - If the "publish_via_partition_root" is *not* set for a publication > then we can always replicate to the tables with the same name as the > non-root tables in publisher. > > Thoughts? > I'd adjust that wording slightly, because "we can always replicate to ..." sounds a bit vague, and saying that an option is set or not set could be misinterpreted, as the option could be "set" to false. How about: - If "publish_via_partition_root" is true for a publication, then data is replicated to the table with the same name as the root (i.e. partitioned) table in the publisher. - If "publish_via_partition_root" is false (the default) for a publication, then data is replicated to tables with the same name as the non-root (i.e. partition) tables in the publisher. ? Regards, Greg Nancarrow Fujitsu Australia
Commits
-
Avoid syncing data twice for the 'publish_via_partition_root' option.
- 062a84442424 16.0 landed
-
Fix partition table's REPLICA IDENTITY checking on the subscriber.
- 52d5ea9adb01 14.5 cited
-
Prohibit combining publications with different column lists.
- fd0b9dcebda7 15.0 cited
-
Fix double publish of child table's data.
- 3f06c00cf6dc 13.6 landed
- 614b77d65a38 14.2 landed
- 5e97905a2c76 15.0 landed
-
Support adding partitioned tables to publication
- 17b9e7f9fe23 13.0 cited