Windows build warnings

Greg Nancarrow <gregn4422@gmail.com>

From: Greg Nancarrow <gregn4422@gmail.com>

To: PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2021-11-22T11:10:10Z

Lists: pgsql-hackers

Attachments

fix_windows_build_warnings.patch (application/octet-stream) patch

Hi,

I'm seeing the following annoying build warnings on Windows (without
asserts, latest Postgres source):

pruneheap.c(858): warning C4101: 'htup': unreferenced local variable
pruneheap.c(870): warning C4101: 'tolp': unreferenced local variable

I notice that these are also reported here: [1]

I've attached a patch to fix these warnings.
(Note that currently PG_USED_FOR_ASSERTS_ONLY is defined as the unused
attribute, which is only supported by GCC)

[1]: https://www.postgresql.org/message-id/CAH2-WznwWU+9on9nZCnZtk7uA238MCTgPxYr1Ty7U_Msn5ZGwQ@mail.gmail.com


Regards,
Greg Nancarrow
Fujitsu Australia

Commits

Disable unused-variable warning C4101 in MSVC
- e7122548a3f7 15.0 landed
Remove PF_USED_FOR_ASSERTS_ONLY from variables in general use
- ac0db34e0e5c 15.0 landed
Fix handling of non-key columns get_index_column_opclass()
- 7e0416039046 13.0 cited