Re: reducing the footprint of ScanKeyword (was Re: Large writable variables)
John Naylor <jcnaylor@gmail.com>
From: John Naylor <jcnaylor@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
Andrew Gierth <andrew@tao11.riddles.org.uk>, Tom Lane <tgl@sss.pgh.pa.us>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2018-12-26T19:45:47Z
Lists: pgsql-hackers
On 12/26/18, Robert Haas <robertmhaas@gmail.com> wrote: > I wonder if we could do something really simple like a lookup based on > the first character of the scan keyword. It looks to me like there are > 440 keywords right now, and the most common starting letter is 'c', > which is the first letter of 51 keywords. So dispatching based on the > first letter clips at least 3 steps off the binary search. I don't > know whether that's enough to be worthwhile, but it's probably pretty > simple to implement. Using radix tree structures for the top couple of node levels is a known technique to optimize tries that need to be more space-efficient at lower levels, so this has precedent. In this case there would be a space trade off of (alphabet size, rounded up) * (size of index to lower boundary + size of index to upper boundary) = 32 * (2 + 2) = 128 bytes which is pretty small compared to what we'll save by offset-based lookup. On average, there'd be 4.1 binary search steps, which is nice. I agree it'd be fairly simple to do, and might raise the bar for doing anything more complex. -John Naylor
Commits
-
Use perfect hashing, instead of binary search, for keyword lookup.
- c64d0cd5ce24 12.0 landed
-
Reduce the size of the fmgr_builtin_oid_index[] array.
- 8ff5f824dca7 12.0 landed
-
Replace the data structure used for keyword lookup.
- afb0d0712f1a 12.0 landed