FindDefinedSymbol() is subtly broken
John Naylor <jcnaylor@gmail.com>
From: John Naylor <jcnaylor@gmail.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-05-19T07:23:43Z
Lists: pgsql-hackers
Attachments
- 0001-Update-FindDefinedSymbol-to-match-current-practice.patch (text/x-patch) patch 0001
- last-minute-script-cleanups.patch (text/x-patch) patch
Long story short: It expects an array of paths, but will die if it can't find the symbol in the first path. Arguably it's a bug, but since the original use case for multiple paths is long gone anyway, it might never occur in practice. The attached patch changes it to expect a single path. Also attached: a few minor build script cleanups I've noticed along the way: -more accurate error message -s/print sprintf/printf/ -a recent perltidy change made a couple multi-line strings look odd, so use heredocs (which other scripts use in this case anyway) -make generated file footers match project style -remove a duplicate comment -John Naylor
Commits
-
Assorted minor cleanups for bootstrap-data Perl scripts.
- e7a808f947c6 11.0 landed