Re: inconsistency and inefficiency in setup_conversion()

John Naylor <jcnaylor@gmail.com>

View thread View on postgr.es

From: John Naylor <jcnaylor@gmail.com>

To: Thomas Munro <thomas.munro@enterprisedb.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2018-05-19T06:41:10Z

Lists: pgsql-hackers

Attachments

v3-0001-Add-pg_language-lookup.patch (text/x-patch) patch v3-0001
v3-0002-Replace-ad-hoc-format-for-conversion-functions.patch (text/x-patch) patch v3-0002
v3-convert_conversion2dat.pl (application/x-perl)

On 5/19/18, Thomas Munro <thomas.munro@enterprisedb.com> wrote:
> Looks good on Windows[1] but now it's broken on Linux[2] (also
> reproducible on my macOS laptop):

That's what happens when I squeeze in a small Makefile change without
testing the build. Fix attached. Thanks again and sorry for the noise.

(In case I didn't mention previously, the Perl script is for
visibility; reviewers/committers don't need to run it.)

-John Naylor

Commits

Move the built-in conversions into the initial catalog data.
- d33faa285b8f 12.0 landed
Use symbolic references for pg_language OIDs in the bootstrap data.
- 814c9019aa7b 12.0 landed