Re: Documentation for bootstrap data conversion
John Naylor <jcnaylor@gmail.com>
From: John Naylor <jcnaylor@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2018-04-09T17:41:06Z
Lists: pgsql-hackers
Attachments
- preserve-all-blank-lines-in-data-files.patch (text/x-patch) patch
On 4/9/18, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> As it is now, it will actually collapse consecutive blank lines into >> one. I maintain that was necessary during conversion to get some >> semblance of consistency, but now it may not be a good idea to tie >> developers' hands in surprising ways if they want double blank lines >> in some places. It would be pretty easy to remove this behavior. >> Apologies if it was not documented well enough. > > I did note that in some internal comments, but forgot it when writing > this. I agree that now that the conversion is done, it'd be better > to remove that special case. Would you send a patch for that? Sure, attached. -John Naylor
Commits
-
Improve consistency of comments in system catalog headers.
- 68c23cba341a 11.0 landed
-
Make reformat_dat_file.pl preserve all blank lines.
- 2cdf359fc447 11.0 landed