Re: WIP: Avoid creation of the free space map for small tables

John Naylor <jcnaylor@gmail.com>

From: John Naylor <jcnaylor@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2018-11-20T08:12:22Z

Lists: pgsql-hackers

I wrote:

> On 11/19/18, Amit Kapila <amit.kapila16@gmail.com> wrote:
> [ abortive states ]
>> I think it might come from any other place between when you set it and
>> before it got cleared (like any intermediate buffer and pin related
>> API's).
>
> Okay, I will look into that.

LockBuffer(), visibilitymap_pin(), and GetVisibilityMapPins() don't
call errors at this level. I don't immediately see any additional good
places from which to clear the local map.

-John Naylor

Commits

Improve code comments in b0eaa4c51b.
- 06c8a5090ed9 12.0 landed
During pg_upgrade, conditionally skip transfer of FSMs.
- 13e8643bfc29 12.0 landed
Add more tests for FSM.
- 6f918159a97a 12.0 landed
Doc: Update the documentation for FSM behavior for small tables.
- 29d108cdecbe 12.0 landed
Make FSM test portable.
- 08ecdfe7e5e0 12.0 landed
Avoid creation of the free space map for small heap relations, take 2.
- b0eaa4c51bbf 12.0 landed
Move page initialization from RelationAddExtraBlocks() to use, take 2.
- 0d1fe9f74e36 12.0 cited
Avoid creation of the free space map for small heap relations.
- ac88d2962a96 12.0 landed
In bootstrap mode, don't allow the creation of files if they don't already
- d66e3664b8ba 12.0 landed